Support symfony UUID #2826
Open
Support symfony UUID #2826
+429
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
support-symfony-uuid
branch
from
f0c625b to
570bfff
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Symfony UUID components by adding a new UUID type and refactoring the ID generation strategy to support auto-generating UUIDs alongside ObjectIds.
- Adds a new
BinaryUuidTypefor mapping Symfony UUID instances to MongoDB Binary with UUID subtype - Refactors AUTO ID generation to support both ObjectId and UUID types through separate generators
- Updates documentation to reflect the new UUID support and deprecates the old UUID generator
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Doctrine/ODM/MongoDB/Types/BinaryUuidType.php | New type implementation for converting between Symfony UUIDs and MongoDB Binary |
| lib/Doctrine/ODM/MongoDB/Types/Type.php | Adds UUID constant and type registration, updates type detection logic |
| lib/Doctrine/ODM/MongoDB/Id/SymfonyUuidGenerator.php | New generator for creating Symfony UUIDs with support for v1, v4, and v7 |
| lib/Doctrine/ODM/MongoDB/Id/ObjectIdGenerator.php | New dedicated generator for ObjectIds, extracted from AutoGenerator |
| lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadataFactory.php | Refactors AUTO generation logic to choose appropriate generator based on field type |
| tests/Doctrine/ODM/MongoDB/Tests/Types/BinaryUuidTypeTest.php | Comprehensive test coverage for the new UUID type |
| tests/Doctrine/ODM/MongoDB/Tests/Functional/UuidMappingTest.php | Functional tests for UUID field mapping and auto-generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GromNaN
reviewed
Sep 20, 2025
GromNaN
reviewed
Sep 23, 2025
GromNaN
reviewed
Sep 23, 2025
alcaeus
force-pushed
the
support-symfony-uuid
branch
from
ce0a752 to
26d71ea
Compare
GromNaN
reviewed
Sep 24, 2025
| throw new Exception(sprintf('Invalid binary data of type %d received for Uuid', $value->getType())); | ||
| } | ||
|
|
||
| return Uuid::fromBinary($value->getData()); |
There was a problem hiding this comment.
I checked that this returns instances of UuidVx.
If there is a miss-match between the UUID version of the value in the database, and the document property type, the user will get a type error, which is perfect.
|
|
||
| namespace Doctrine\ODM\MongoDB\Types; | ||
|
|
||
| use Exception; |
There was a problem hiding this comment.
Suggested change
| use Exception; | |
| use Doctrine\ODM\MongoDB\MongoDBException; |
| } | ||
|
|
||
| if ($value->getType() !== Binary::TYPE_UUID) { | ||
| throw new Exception(sprintf('Invalid binary data of type %d received for Uuid', $value->getType())); |
There was a problem hiding this comment.
Having a more specific exception make it catchable.
Suggested change
| throw new Exception(sprintf('Invalid binary data of type %d received for Uuid', $value->getType())); | |
| throw MongoDBException::invalidValueForType(sprintf('Invalid binary data of type %d received for Uuid', $value->getType())); |
Comment on lines
+2115
to
+2126
| - | ||
| message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertSame\(\) with arguments MongoDB\\BSON\\Binary, null and ''Binary UUIDs are…'' will always evaluate to false\.$#' | ||
| identifier: staticMethod.impossibleType | ||
| count: 1 | ||
| path: tests/Doctrine/ODM/MongoDB/Tests/Types/BinaryUuidTypeTest.php | ||
|
|
||
| - | ||
| message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertSame\(\) with arguments Symfony\\Component\\Uid\\UuidV4, null and ''Uuid objects are…'' will always evaluate to false\.$#' | ||
| identifier: staticMethod.impossibleType | ||
| count: 1 | ||
| path: tests/Doctrine/ODM/MongoDB/Tests/Types/BinaryUuidTypeTest.php | ||
|
|
There was a problem hiding this comment.
Which lines are this errors. Is it a false-positive due to the way the PHP extension can by-pass userland rules?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new type to map Symfony UUID instances to a BSON Binary with subtype UUID. In addition, the existing
AutoGeneratoris replaced by separateObjectIdGeneratorandUUIDGeneratorto support auto-generating new object IDs.TODO:
AUTOstrategy.